Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a more convenient overload of AddPasswordlessSdk #81

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Add a more convenient overload of AddPasswordlessSdk #81

merged 4 commits into from
Nov 24, 2023

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Nov 23, 2023 •
edited
Loading

Before (not AOT-compatible, ugly, requires extra packages):

services.AddPasswordlessSdk(options =>
{
    Configuration.GetRequiredSection("Passwordless").Bind(options);
});

After (perfection):

services.AddPasswordlessSdk(Configuration.GetRequiredSection("Passwordless"));

abergs
abergs approved these changes Nov 24, 2023
View reviewed changes
src/Passwordless/ServiceCollectionExtensions.cs Outdated Show resolved Hide resolved
@Tyrrrz Tyrrrz merged commit c9303c5 into main Nov 24, 2023
4 checks passed
@Tyrrrz Tyrrrz deleted the better-addpasswordless branch November 24, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abergs abergs abergs approved these changes

@jonashendrickx jonashendrickx Awaiting requested review from jonashendrickx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyrrrz @abergs